Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-dom): undefined cssvars should not be bound to the element #7475

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+4 −2
Open

fix(runtime-dom): undefined cssvars should not be bound to the element #7475

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d070ab6
fix(runtime-dom): undefined cssvars should not be bound to the element
baiwusanyu-c Jan 6, 2023
3bc3412
fix(runtime-core): update code
baiwusanyu-c Jan 6, 2023
91aa700
fix(runtime-core): update code
baiwusanyu-c Jan 8, 2023
88f0e09
fix(runtime-core): update code
baiwusanyu-c Jan 9, 2023
6b36b86
[autofix.ci] apply automated fixes
autofix-ci[bot] Dec 19, 2023
b87b46e
Merge branch 'main' into bwsy/fix/CSSVarsUndefined
baiwusanyu-c Jan 3, 2024
46d0537
Merge branch 'main' into bwsy/fix/CSSVarsUndefined
baiwusanyu-c Apr 16, 2024
dca7aba
Merge branch 'main' into bwsy/fix/CSSVarsUndefined
baiwusanyu-c Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/runtime-dom/src/helpers/useCssVars.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,10 @@ function setVarsOnNode(el: Node, vars: Record<string, string>) {
const style = (el as HTMLElement).style
let cssText = ''
for (const key in vars) {
style.setProperty(`--${key}`, vars[key])
cssText += `--${key}: ${vars[key]};`
if (vars[key] != null) {
style.setProperty(`--${key}`, vars[key])
cssText += `--${key}: ${vars[key]};`
}
}
;(style as any)[CSS_VAR_TEXT] = cssText
}
Expand Down