-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use git default short commit-id #7761
Conversation
@sxzz Do you have a minute to review this PR ? THX |
What is the point of this? The original uses 7 chars which is consistent with the GitHub short format. |
It may create a non-unique commit id by slicing 7 lengths. (Although the current probability is very unlikely)
Further read: https://stackoverflow.com/questions/18134627/how-much-of-a-git-sha-is-generally-considered-necessary-to-uniquely-identify-a |
After looking at where we are using these short commit ids, I think we should keep this consistent with GitHub’s format. |
@yyx990803 @sxzz @Justineo Updated. Is this commit necessary any more ? |
Size ReportBundles
Usages
|
Signed-off-by: JayFate <48240828+JayFate@users.noreply.github.com>
before this commit
after this commit