Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v-model): fix the lazy modifier is not reset by other modifications #8547

Merged
merged 7 commits into from
May 31, 2024
Merged

fix(v-model): fix the lazy modifier is not reset by other modifications #8547

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
345b048
fix(v-model): fix lazy modifier not syncing external changes
Alfred-Skyblue Jun 12, 2023
7d87ec6
fix(v-model): update value synchronously when updating value
Alfred-Skyblue Jun 12, 2023
6333034
Merge branch 'main' into fix-vModel
Alfred-Skyblue Jul 10, 2023
aafea15
Merge branch 'main' into fix-vModel
Alfred-Skyblue Aug 15, 2023
212ae3c
Merge branch 'main' into fix-vModel
Alfred-Skyblue Aug 21, 2023
016259f
chore: merge conflict
Alfred-Skyblue Aug 22, 2023
f30990c
Merge branch 'main' into fix-vModel
Alfred-Skyblue Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/runtime-dom/src/directives/vModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,11 @@ export const vModelText: ModelDirective<
mounted(el, { value }) {
el.value = value == null ? '' : value
},
beforeUpdate(el, { value, modifiers: { lazy, trim, number } }, vnode) {
beforeUpdate(
el,
{ value, oldValue, modifiers: { lazy, trim, number } },
vnode
) {
el[assignKey] = getModelAssigner(vnode)
// avoid clearing unresolved text. #2302
if ((el as any).composing) return
Expand All @@ -93,7 +97,8 @@ export const vModelText: ModelDirective<
}

if (document.activeElement === el && el.type !== 'range') {
if (lazy) {
// #8546
if (lazy && value === oldValue) {
return
}
if (trim && el.value.trim() === newValue) {
Expand Down