Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(runtime-core): prevent users from manually calling lifecycle hook function #8731

Merged
merged 8 commits into from
May 27, 2024
Merged

refactor(runtime-core): prevent users from manually calling lifecycle hook function #8731

merged 8 commits into from
May 27, 2024

Conversation

Alfred-Skyblue
Copy link
Member

@Alfred-Skyblue Alfred-Skyblue commented Jul 6, 2023 •
edited
Loading

We should make the lifecycle function return void to prevent users from manually calling the lifecycle function.

demo

@sxzz sxzz added the ready to merge The PR is ready to be merged. label Aug 15, 2023
@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.4 kB (-1 B) 32.9 kB (-3 B) 29.7 kB (-11 B)
vue.global.prod.js 132 kB (-1 B) 49.6 kB 44.5 kB (-68 B)

Usages

Name Size Gzip Brotli
createApp 48 kB (-1 B) 18.9 kB (-1 B) 17.2 kB (+1 B)
createSSRApp 51.2 kB (-1 B) 20.2 kB (-2 B) 18.4 kB (-6 B)
defineCustomElement 50.4 kB (-1 B) 19.7 kB (-1 B) 17.9 kB (-1 B)
overall 61.3 kB (-1 B) 23.7 kB (-1 B) 21.6 kB (+1 B)

@yyx990803 yyx990803 merged commit ae36b1a into vuejs:main May 27, 2024
11 checks passed
@Alfred-Skyblue Alfred-Skyblue deleted the fix-apiLifecylce branch May 28, 2024 02:05
lynxlangya pushed a commit to lynxlangya/core that referenced this pull request May 30, 2024
@Alfred-Skyblue @lynxlangya
refactor(runtime-core): prevent users from manually calling lifecycle…
ddd1d74 
… hook function (vuejs#8731)
@kikuomax kikuomax mentioned this pull request Aug 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirtles-code skirtles-code skirtles-code left review comments

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged.
Projects
Issue / PR Management
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alfred-Skyblue @sxzz @skirtles-code @yyx990803