Skip to content

types(reactivity): fix reactive collection types #8960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2023
Merged

types(reactivity): fix reactive collection types #8960

merged 2 commits into from
Nov 30, 2023

Conversation

@sxzz
Copy link
Member

@sxzz sxzz commented Aug 12, 2023

closes #8904

@sxzz sxzz added the ready to merge The PR is ready to be merged. label Aug 12, 2023
@sxzz sxzz changed the title fix(reactivity): reactive collection types types(reactivity): fix reactive collection types Aug 21, 2023
@sxzz sxzz mentioned this pull request Oct 13, 2023
Closed
@sxzz sxzz force-pushed the fix/collection-types branch from 1ea5328 to 5ca3dba Compare November 21, 2023 07:40
@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.5 kB 32.9 kB 29.7 kB
vue.global.prod.js 132 kB 49.6 kB 44.5 kB

Usages

Name Size Gzip Brotli
createApp 48 kB 18.9 kB 17.2 kB
createSSRApp 51.2 kB 20.2 kB 18.4 kB
defineCustomElement 50.4 kB 19.7 kB 17.9 kB
overall 61.4 kB 23.7 kB 21.6 kB

@yyx990803 yyx990803 merged commit ad27473 into main Nov 30, 2023
@yyx990803 yyx990803 deleted the fix/collection-types branch November 30, 2023 18:33
antfu added a commit to vueuse/vueuse that referenced this pull request Dec 4, 2023
@antfu
fix(useMemoize): use shallowReactive to wrap Map
fecbe00 
vuejs/core#8960
@skywalker512 skywalker512 mentioned this pull request Dec 5, 2023
Closed
@LinusBorg LinusBorg mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LinusBorg LinusBorg LinusBorg approved these changes

+1 more reviewer

@pikax pikax pikax approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge The PR is ready to be merged.

Projects

Issue / PR Management
Status: Merged

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

type of reactive collection values is abnormal

5 participants

@sxzz @LinusBorg @pikax @yyx990803