-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types(runtime-core): add OnCleanup
parameter type in this.$watch
#9371
Merged
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
Alfred-Skyblue
changed the title
types(apiWatch): add
types(runtime-core): add Oct 10, 2023
OnCleanup
parameter type in instanceWatch
OnCleanup
parameter type in instanceWatch
pikax
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pikax
added
ready to merge
The PR is ready to be merged.
🧹 p1-chore
Priority 1: this doesn't change code behavior.
labels
Oct 13, 2023
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
haoqunjiang
approved these changes
May 27, 2024
haoqunjiang
changed the title
types(runtime-core): add
types(runtime-core): add May 27, 2024
OnCleanup
parameter type in instanceWatch
OnCleanup
parameter type in this.$watch
❌ Deploy Preview for vue-next-template-explorer failed.
|
lynxlangya
pushed a commit
to lynxlangya/core
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧹 p1-chore
Priority 1: this doesn't change code behavior.
ready to merge
The PR is ready to be merged.
scope: reactivity
scope: types
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
onCleanup
parameter is not exposed in the$watch
method ofComponentPublicInstance
, resulting in a type error.Expected:
Actual: