Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(compiler-sfc): defineOptions avoid redundant conditional judgments #9453

Merged
merged 26 commits into from
May 27, 2024
Merged

refactor(compiler-sfc): defineOptions avoid redundant conditional judgments #9453

merged 26 commits into from
May 27, 2024

Conversation

Simon-He95
Copy link
Contributor

No description provided.

sxzz
sxzz reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use switch syntax

@Simon-He95
Copy link
Contributor Author

Let's use switch syntax让我们使用开关语法

sure

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.4 kB 32.9 kB 29.6 kB
vue.global.prod.js 132 kB 49.6 kB 44.5 kB

Usages

Name Size Gzip Brotli
createApp 48 kB 18.9 kB 17.3 kB
createSSRApp 51.1 kB 20.1 kB 18.4 kB
defineCustomElement 50.3 kB 19.7 kB 17.9 kB
overall 61.3 kB 23.7 kB 21.6 kB

@netlify
Copy link

netlify bot commented Oct 24, 2023

❌ Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit 2e96b39
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/653854f772c3270008ee8b77

@skirtles-code skirtles-code mentioned this pull request Oct 26, 2023
Closed
@haoqunjiang haoqunjiang added the 🧹 p1-chore Priority 1: this doesn't change code behavior. label Mar 29, 2024
@skirtles-code
Copy link
Contributor

The PR title currently indicates that this is a perf change. I wonder whether it'd be more accurate to describe it as a refactor?

I suspect the performance improvement is negligible at best, so it might be misleading having it listed as a performance improvement in the changelog.

@Simon-He95 Simon-He95 changed the title perf(compiler-sfc): defineOptions avoid redundant conditional judgments refactor(compiler-sfc): defineOptions avoid redundant conditional judgments Apr 18, 2024
@yyx990803 yyx990803 merged commit 56f5692 into vuejs:main May 27, 2024
5 checks passed
lynxlangya pushed a commit to lynxlangya/core that referenced this pull request May 30, 2024
@Simon-He95 @lynxlangya
refactor(compiler-sfc): defineOptions avoid redundant conditional jud…
249a931 
…gments (vuejs#9453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baiwusanyu-c baiwusanyu-c baiwusanyu-c approved these changes

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Simon-He95 @skirtles-code @sxzz @baiwusanyu-c @yyx990803 @haoqunjiang