Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(reactivity): refactor effects #9480

Closed
wants to merge 19 commits into from
Closed
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions packages/reactivity/src/effect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -396,16 +396,13 @@ export function triggerEffects(
) {
// spread into array for stabilization
const effects = isArray(dep) ? dep : [...dep]
for (const effect of effects) {
if (effect.computed) {
effects
.filter(effect => {
if (!effect.computed) return true
triggerEffect(effect, debuggerEventExtraInfo)
}
}
for (const effect of effects) {
if (!effect.computed) {
triggerEffect(effect, debuggerEventExtraInfo)
}
}
return false
})
.forEach(effect => triggerEffect(effect, debuggerEventExtraInfo))
Simon-He95 marked this conversation as resolved.
Show resolved Hide resolved
Simon-He95 marked this conversation as resolved.
Show resolved Hide resolved
}

function triggerEffect(
Expand Down