Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reactivity): remove Symbol.observable #968

Merged
merged 2 commits into from
Apr 16, 2020
Merged

fix(reactivity): remove Symbol.observable #968

merged 2 commits into from
Apr 16, 2020

Commits on Apr 16, 2020

  1. chore: add @types/node as an explicit dependency 

    As `tsconfig.json` references it, it should be listed in the dependencies.
It currently uses an older version: this commit also bumps to the latest v12 version, and fixes a typing issue.
    @cexbrayat
    cexbrayat committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    d3c1b20 View commit details
    Browse the repository at this point in the history

  2. fix(reactivity): remove Symbol.observable 

    `Symbol.observable` is brought by `@types/node@12` and is not a "well-known" typescript symbol https://www.typescriptlang.org/docs/handbook/symbols.html that can be find in lib.es20xx like the others. It has been removed in `@types/node@v13`.
It means that an application using vue@3.0.0-alpha.13 does not compile unless it explicitely adds `@types/node@v12` as a dependency and `node` in its own tsconfig types.
    @cexbrayat
    cexbrayat committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    0171fac View commit details
    Browse the repository at this point in the history