fix(runtime-core): support deep: false when watch reactive #9928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
CodSpeed Performance ReportMerging #9928 will not alter performanceComparing Summary
|
yangxiuxiu1115
force-pushed
the
fix/watch
branch
2 times, most recently
from
f459a71
to
2bab130
Compare
yyx990803
reviewed
Dec 30, 2023
| @@ -464,3 +465,23 @@ export function traverse(value: unknown, seen?: Set<unknown>) { | |||
| } | |||
| return value | |||
| } | |||
|
|
|||
| export function shallowTraverse(value: unknown) { | |||
There was a problem hiding this comment.
Should be able to reuse traverse by adding a second argument:
traverse(value: unknown, shallow = false, seen?: Set<unknown>)
|
I added a |
|
@Alfred-Skyblue I like the depth idea, but it is a feature so I refactored this PR to use your depth-based |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9916