chore(pnpm-workspace.yaml): packages/* in the pnpm-workspace.yaml is vague, it would be better to list specific package names #9968
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose: Better for managing packages of vuejs/core
As vuejs/core project grows, it would be better to list specific package names, which can be more clear to see how many packages in the project when using pnpm as package manager.
Why this commit ?
An error shown when running pnpm build:
../packages/reactivity-transform/package.json is not found
Above error gave me a confusing for a short time, and after comparing the remote vuejs/core code repo with local code base, making sure this empty folder should not be appear in the project.
Benefits
If the specific package name listed in the pnpm-workspace.yaml, there would be 2 benefits apparently
Adding package would be more clear in the project, as it must be handled by pnpm in the pnpm-workspace.yaml
As packages reference for folders in the packages, which holding so many packages in the vuejs/core project that pnpm-workspace.yaml file can be compared with existed packages in the packages folder.