Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use --build for type-checking to be exhaustive and less-fragile #274

Merged
merged 8 commits into from
Dec 4, 2023
Merged

fix: use --build for type-checking to be exhaustive and less-fragile #274

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b13089f
fix: use `--build` for type-checking to be exaustive and less-fragile
haoqunjiang May 12, 2023
9eaeb65
fix: add `--force` to make it work consistently
haoqunjiang May 12, 2023
47cfc83
Merge branch 'main' into fix-type-check
haoqunjiang May 12, 2023
fc344d5
Merge branch 'main' into fix-type-check
haoqunjiang Nov 27, 2023
57cc076
fix: add missing `noEmit: true` in nightwatch tsconfigs
haoqunjiang Nov 30, 2023
0a82127
fix: add missing vite-plugin-nightwatch dependency
haoqunjiang Nov 30, 2023
9b2e124
chore: merge branch 'main' into fix-type-check
haoqunjiang Nov 30, 2023
f75fd98
chore: update lockfile
haoqunjiang Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions template/base/_gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,5 @@ coverage
*.njsproj
*.sln
*.sw?

*.tsbuildinfo
2 changes: 1 addition & 1 deletion template/config/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"scripts": {
"build": "run-p type-check \"build-only {@}\" --",
"build-only": "vite build",
"type-check": "vue-tsc --noEmit -p tsconfig.app.json --composite false"
"type-check": "vue-tsc --build --force"
},
"devDependencies": {
"@types/node": "^18.18.10",
Expand Down
1 change: 1 addition & 0 deletions template/tsconfig/base/tsconfig.app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"exclude": ["src/**/__tests__/*"],
"compilerOptions": {
"composite": true,
"noEmit": true,
"baseUrl": ".",
"paths": {
"@/*": ["./src/*"]
Expand Down
1 change: 1 addition & 0 deletions template/tsconfig/base/tsconfig.node.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
],
"compilerOptions": {
"composite": true,
"noEmit": true,
"module": "ESNext",
"moduleResolution": "Bundler",
"types": ["node"]
Expand Down
5 changes: 0 additions & 5 deletions template/tsconfig/cypress-ct/package.json
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions template/tsconfig/vitest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
{
"scripts": {
"type-check": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false"
},
"devDependencies": {
"@types/jsdom": "^21.1.5"
}
Expand Down