-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(vuex): "_isBuffer" is not defined on the instance warning from Vue,
closes #955
- Loading branch information
Guillaume Chau
committed
Apr 5, 2019
1 parent
cfee9f6
commit 2ff9785
Showing
1 changed file
with
13 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ff9785
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you feel about changing the error from "on the instance warning" to something else... Ideas are the following... Instance and Warning make me think of Object Instances or Server Instances.
2ff9785
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are you talking about? 😸
2ff9785
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were on Slack today. And I wasn't sure what that error meant, right away. Someone explained it to me. So I suggested that we rewrite the error to be a little more friendly to the newbies like myself.