Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typescript] add type definitions #779

Open
championswimmer opened this issue Sep 23, 2018 · 5 comments
Open

[Typescript] add type definitions #779

championswimmer opened this issue Sep 23, 2018 · 5 comments

Comments

@championswimmer
Copy link

What problem does this feature solve?

stops typescript from complaining of absent type declarations

What does the proposed API look like?

A very simple

declare module '@vue/devtools' {
  const connect(host: string, port: string): void
}

will do. only required so that we can do

import devtools from '@vue/devtools'
devtools.connect()
@karanisverma
Copy link
Contributor

Hey @Akryum can I pick this up?

@Akryum
Copy link
Member

Akryum commented Nov 26, 2018

Of course! :)

@karanisverma
Copy link
Contributor

Thanks @Akryum, Looking into this

@championswimmer
Copy link
Author

I think both host and port are optional, so my given example is not 100% correct.
So it should be host?: string, port?: string in the arguments

@karanisverma
Copy link
Contributor

Hi @Akryum I have created a PR please have a look, @championswimmer this is 1st time around when i am creating type definition. Please let me know if I have done some mistake. Thanks in advance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants