[Typescript] added type definitions #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karanisverma
force-pushed
the
dev
branch
3 times, most recently
from
0ffb0dd
to
bf0cbd6
Compare
championswimmer
approved these changes
Dec 5, 2018
|
@Akryum Why this PR is not getting Merged? Please let me know if there is something which need to be fixed here. |
|
I think set port to |
|
sure will make this change! Thanks @yoyoys |
|
@posva does these changes looks good ? |
|
I don't know. I haven't followed dev tools dev since @Akryum picked them up. I didn't know you could install DevTools as a package now. He will look at it whenever he has time. But to be honest this looks like low priority compared to bugs and features so it may take a while |
|
Thanks @posva 🙂 |
|
@Akryum |
simsim0709
pushed a commit
to simsim0709/vue-devtools
that referenced
this pull request
May 7, 2019
* feat: added typing for connect * fix: updated port type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added type def for connect.
Issue: #779