Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser plugin fails loading with t.isBuffer is not a function #874

Closed
juliushaertl opened this issue Feb 4, 2019 · 9 comments
Closed

Comments

@juliushaertl
Copy link

Version

5.0.0-beta.4

Browser and OS info

Chromium 72, Firefox 65

Steps to reproduce

Create a simple vue app that uses a vuex store

const debug = process.env.NODE_ENV !== 'production'

export default new Vuex.Store({
	modules: {
		myModule
	},
	strict: debug
})

What is expected?

vue-devtools work as expected

What is actually happening?

The javascript console shows the following error:

TypeError: t.isBuffer is not a function[Learn More] eval:1:1695

    y (index):1 u (index):1 <anonymous> (index):1 r (index):1 emit (index):1 devtoolPlugin vuex.esm.js:51 Store vuex.esm.js:347 js index.js:30 Bootstrap27Webpack

image


The culprit line from vue-devtools seems to be https://github.com/vuejs/vue-devtools/blob/cf74ad3ce66534ea028e953ca4ccf85835114f7f/src/backend/hook.js#L186

@jaketoolson
Copy link

Happening to me now suddenly too.

@Akryum
Copy link
Member

Akryum commented Mar 25, 2019

This seems related to pvorb/clone#104

@TheDutchCoder
Copy link

TheDutchCoder commented Mar 26, 2019

Yes this is a breaking change for me too. I can't actually work currently because I can't debug my app anymore.

Can you please roll back this version in the meantime?

@gotexis
Copy link

gotexis commented Apr 5, 2019

My situation is a bit different, I got this

Property or method "_isBuffer" is not defined on the instance but referenced during render.
Make sure that this property is reactive, either in the data option,
 or for class-based components, by initializing the property. See: 
https://vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.

x 100 times

@JFonsecaSpot
Copy link

x 100 times

Same error message.
Having thousands really, and halting the browser for massive periods. Unusable atm.

My bet: might it be related to using arrow functions on array callbacks. Maybe something related to a polyfil? If that's the case, arrow function context spec cannot be subverted by the used poli and this should to be changed, (but who am I)

Looking to downgrade the extension while this is not fixed.

@Akryum
Copy link
Member

Akryum commented Apr 5, 2019

@gotexis @JFonsecaSpot Your issue is different, please comment and provide more info and runnable minimal reproduction in the actual issue: #955

@JFonsecaSpot
Copy link

@Akryum couldn't reproduce with CLI3 generated app. Maybe an interaction with our main app configuration. Looking at the error stack instead. If I have time later will try to reproduce on a minimal repo with the same configuration.

@JFonsecaSpot
Copy link

@Akryum Can you tell if this b4e19c3 reached the production build / chrome extension store?

I am not able to reproduce the issue anymore and that coomit seams to be a good candidate for the fix.

@Akryum
Copy link
Member

Akryum commented Apr 5, 2019

@JFonsecaSpot If you look at the commits, it's after the last release (5.0.7).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants