Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): enable CORS for socket.io server (fix #1813) #1815

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

brownsugar
Copy link
Contributor

@brownsugar brownsugar commented Mar 25, 2022

close #1813

Description

Added the cors origin config to socket.io server.

Additional context

Socket.IO - Migrating from 2.x to 3.0 - CORS handling

https://socket.io/docs/v4/migrating-from-2-x-to-3-0/#cors-handling

CORS - Configuration Options

https://github.com/expressjs/cors#configuration-options


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@Akryum Akryum merged commit dc9d010 into vuejs:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

socket.io polling request blocked by CORS policy in Electron
2 participants