-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Vue router (adds routing tab) #272
Conversation
Wow, this is impressive. There is a little bug preventing from running it. |
@bartlomieju Thanks for the catch. Fixed now. |
Wow, so cool! How does it look with a smaller width (~500px)? |
@posva This is how it looks like with ~500px. You can of course change the size of all panes with drag and drop. |
First of all, this is awesome and thanks a lot for the contribution! That said, there are a few things that I think can be improved regarding the UX. It would probably be better if we discussed the design for the router panel before the implementation.
What I would've went with:
I know this is quite different from what you have implemented, so don't feel any obligations to implement these. I just want to make sure we ship something that is useful enough to warrant an extra tab. |
Hey @yyx990803 , I can totally understand that you want to go in a different direction regarding the UI/UX. Unfortunately I have no time to work on it right now. So feel free to do whatever you want with this pull request. |
Hello, @yyx990803 I checked code, and there is a lot to do with it still. i started working on it cus @markussorg have to time. I'm following requirements
History of routing is not really helpful but in some scenarios can be useful that's why we should keep it on separated tab. If you guys decide to trash it we can do this more easily. For now i'm slowly updating it to work with https://github.com/markussorg/vue-devtools/pull/1 |
@armano2 Thanks for picking up the work! |
Can we perhaps close this PR already in favor of #322 @yyx990803 ? |
This will add Vue router support with the following features: