Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use prototype toString to prevent bad serialization #569

Merged
merged 3 commits into from
Jan 26, 2018
Merged

Use prototype toString to prevent bad serialization #569

merged 3 commits into from
Jan 26, 2018

Conversation

simplesmiler
Copy link
Member

Should fix #568

@simplesmiler
Copy link
Member Author

simplesmiler commented Jan 25, 2018 •
edited
Loading

Functions that failed to be serialized properly will now show (?) as parameters.

@Akryum Akryum added this to the v4.1.2 milestone Jan 26, 2018
@Akryum
Copy link
Member

Akryum commented Jan 26, 2018

Made it work anyway (but just in case, I left your check). 😄

@Akryum Akryum changed the title Edge case of incorrectly serialized function Use prototype toString to prevent bad serialization Jan 26, 2018
@Akryum Akryum merged commit 6bb181d into vuejs:master Jan 26, 2018
@simplesmiler
Copy link
Member Author

👍 for Function.prototype.toString.call, didn't even cross my mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akryum Akryum Akryum approved these changes

Assignees
No one assigned
Labels
bug semver-patch
Projects
None yet
Milestone
v4.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@simplesmiler @Akryum