fix: Revert using ref/watch

vuejs · Feb 26, 2024 · a5c1688 · a5c1688
1 parent f6401c1
commit a5c1688
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/packages/devtools-kit/__tests__/api/plugin.test.ts b/packages/devtools-kit/__tests__/api/plugin.test.ts
@@ -31,7 +31,7 @@ describe('vue plugin', () => {
     await new Promise<void>((resolve) => {
       devtools.hook.on.vueAppInit(() => {
         const [appRecord] = devtoolsAppRecords.value
-        expect(devtools.state.pluginBuffer.value.findIndex(([descriptor]) => descriptor.packageName === 'vue-router')).toBeGreaterThanOrEqual(0)
+        expect(devtools.state.pluginBuffer.findIndex(([descriptor]) => descriptor.packageName === 'vue-router')).toBeGreaterThanOrEqual(0)
         expect(appRecord.moduleDetectives?.vueRouter).toBe(true)
         resolve()
       })

diff --git a/packages/devtools-kit/src/core/app-record/index.ts b/packages/devtools-kit/src/core/app-record/index.ts
@@ -75,7 +75,7 @@ export async function toggleActiveAppRecord(id: string) {
   devtoolsContext.clear()
   const appRecord = devtoolsAppRecords.value.find(record => record.id === id)
   if (appRecord) {
-    devtoolsState.pluginBuffer.value = devtoolsState.pluginBuffer.value.filter(([plugin]) => plugin.id !== 'components')
+    devtoolsState.pluginBuffer = devtoolsState.pluginBuffer.filter(([plugin]) => plugin.id !== 'components')
     const api = new DevToolsPluginApi()
     appRecord.api = api
     setActiveAppRecord(appRecord)

diff --git a/packages/devtools-kit/src/state/state.ts b/packages/devtools-kit/src/state/state.ts
@@ -1,4 +1,3 @@
-import { ref } from 'vue'
 import { target as global } from '@vue/devtools-shared'
 import { debounce } from 'perfect-debounce'
 import type { DevToolsState } from '../types'
@@ -15,7 +14,7 @@ function initStateFactory() {
     appRecords: [],
     activeAppRecord: null,
     selectedComponentId: null,
-    pluginBuffer: ref([]),
+    pluginBuffer: [],
     tabs: [],
     commands: [],
     vitePluginDetected: false,

diff --git a/packages/devtools-kit/src/types/state.ts b/packages/devtools-kit/src/types/state.ts
@@ -1,4 +1,3 @@
-import type { Ref } from 'vue'
 import type { CustomCommand } from '../core/custom-command'
 import type { CustomTab } from '../core/custom-tab'
 import type { AppRecord, PluginDescriptor, PluginSetupFunction } from './app'
@@ -10,7 +9,7 @@ export interface DevToolsState {
   appRecords: AppRecord[]
   activeAppRecord: AppRecord | null
   selectedComponentId: string | null
-  pluginBuffer: Ref<[PluginDescriptor, PluginSetupFunction][]>
+  pluginBuffer: [PluginDescriptor, PluginSetupFunction][]
   tabs: CustomTab[]
   commands: CustomCommand[]
   activeAppRecordId: string | null