fix(devtools-kit): dynamically register setupFn of plugins #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-devtools-docs canceled.
|
Azurewarth0920
force-pushed
the
fix/reregister-on-pinia-module-loaded
branch
from
81c7150 to
f6401c1
Compare
Azurewarth0920
changed the title
webfansplz
reviewed
Feb 25, 2024
webfansplz
changed the title
webfansplz
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #246
As described in the issue, the plugin registration only called on initiation.
The lazy-loaded modules (eg. pinia) will not be registered when loaded, reproduced in #246,
Watch on the
pluginBuffer, when a new plugin descriptor and setupFn are added, register the plugin.#246 (comment)
The cause of this behavior is when we import
useAppStoreinApp.vue, the plugin descriptor and the setupFn will be pushed into pluginBuffer before initiation. So the plugin can be correctly activated.