Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): route param regex overflows container #266

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix(client): route param regex overflows container #266

merged 1 commit into from
Mar 5, 2024

Conversation

adamdehaven
Copy link
Contributor

@adamdehaven adamdehaven commented Mar 5, 2024

Truncate the path to account for custom regex in the route params. Fixes #235.

To illustrate, you can define a route with custom regex in the param as seen here for a UUID:

{
  path: '/hello/:id([0-9a-fA-F]{8}\\-[0-9a-fA-F]{4}\\-[0-9a-fA-F]{4}\\-[0-9a-fA-F]{4}\\-[0-9a-fA-F]{12})',
  component: () => import('./pages/Hello.vue'),
  name: 'hello',
}

Before

route path overflowing container

After

route path truncated

Truncate the path to account for custom regex in the route params. Fixes #235.
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 1e7f85c
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/65e686e7a7904800071d54cb

@webfansplz
Copy link
Member

Thanks.

@webfansplz webfansplz merged commit 76a0048 into vuejs:main Mar 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: long route paths overflow the inspector
3 participants