feat(kit): optimize editing on native set #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Azurewarth0920
commented
Mar 8, 2024
•
Azurewarth0920
commented
- Optimize editing on the native set.
- Adding values to set.
- Deleting object value in the set.
- Disable modification on value in the set.
- Value in set should be unable to be modified. (can be added or removed)
- Add tests for devtools-kit/editor.
✅ Deploy Preview for vue-devtools-docs canceled.
|
Azurewarth0920
commented
Mar 8, 2024
| @@ -79,7 +80,7 @@ export class StateEditor { | |||
| else if (toRaw(object) instanceof Map) | |||
| object.delete(field) | |||
| else if (toRaw(object) instanceof Set) | |||
| object.delete(value) | |||
There was a problem hiding this comment.
object.delete(value) can not delete object-typed value in set.
webfansplz
approved these changes
Mar 11, 2024
webfansplz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.