Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): toggle app when inspecting #748

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kevinluo201
Copy link

@kevinluo201 kevinluo201 commented Dec 19, 2024

Try to fix #718

  • Call toggleApp if the activeAppRecordId is different from the inspected component's app id
  • Add options to toggleApp and related methods, so { inspectingComponent: true } can eventually be sent to core's registerDevToolsPlugin to ignore highPerfModeEnabled

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit efd964f
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/676a3b99e574a60009514e12

@kevinluo201 kevinluo201 marked this pull request as ready for review December 24, 2024 04:45
@kevinluo201
Copy link
Author

The feature is implemented, however, I added an extra option inspectingComponent at many places. If anyone has a better way to handle this, or to manage the global state, please help me, thanks!

@alexzhang1030 alexzhang1030 changed the title Toggle app when inspecting feat(kit): toggle app when inspecting Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot select a component in another App if there are multiple Apps on the page
1 participant