Skip to content

feat: add french translations repo link #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

edimitchel
Copy link
Contributor

@edimitchel edimitchel commented Oct 24, 2022

Description of Problem

French translation docs is missing.

Proposed Solution

Here the link for getting the link from the english version.

Additional Information

We need to translate the current version of fr.vuejs.org to v2.fr.vuejs.org. The repo responsible of the current version is https://github.com/vuejs-fr/vuejs.org.

Check-up list before merge:

@netlify
Copy link

netlify bot commented Oct 24, 2022

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit b0779be
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/637650cc64033800084e3305
😎 Deploy Preview https://deploy-preview-2048--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yyx990803
Copy link
Member

We discussed this and I think it's better to switch the official URLs over when the v3 translation has a significant portion complete - e.g. above 50%. We can use the Netlify deployment URL for this PR for now just to get exposure / contributors.

@yyx990803 yyx990803 merged commit 9e0fc14 into vuejs:main Nov 17, 2022
Alex-Sokolov referenced this pull request in vuejs-translations/docs-ru Nov 18, 2022
Co-authored-by: Michel EDIGHOFFER <edimitchel@gmail.com>
Alex-Sokolov referenced this pull request in vuejs-translations/docs-ru Nov 18, 2022
…omments in my last PR vuejs/docs#1847 - I fixed the images linksThis PR mainly changes the links to new ones and updates the prices & adds links to our plugins as they may be of interest to your users.If there are any problems again, please let me know.Thanks,Mateusz (#73) (#74)

* feat: add french translations repo link (#2048)

* Update themes.json (#2089)

Hi!

sorry for posting this again but I missed your comments in my last PR vuejs/docs#1847 - I fixed the images links

This PR mainly changes the links to new ones and updates the prices & adds links to our plugins as they may be of interest to your users.

If there are any problems again, please let me know.

Thanks,
Mateusz

Co-authored-by: Michel EDIGHOFFER <edimitchel@gmail.com>
Co-authored-by: Mateusz <m.leciejewski@mdbootstrap.com>
@edimitchel edimitchel deleted the feat/french-translation-link branch February 2, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted When you need help with how to solve the issue, use this label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants