Add Scrimba links and refactor VueSchoolLink to a more reusable component #3240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Looking at the changes, perhaps it's better to simply duplicate a |
|
Got it. I've updated the PR to use a newly created ScrimbaLink component instead of the refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Scrimba is a Vue sponsor, so we have recorded a few Scrimba screencasts to give people reading the docs an alternative interactive walkthrough of various articles. These have been reviewed and approved by Evan You.
When added these, there was an issue with the VueSchoolLink component not being reusable.
Proposed Solution
I refactored the VueSchoolLink into a general PromoLink so that the component is more reusable. Have updated all Vue School and Scrimba links to use this new component.
I have not deleted the VueSchoolLink from the .vitepress directory. Let me know if you want me to do this as well.