fix: use a custom typings directory

Fixes language-tools test failure. Closes vuejs/language-tools#3759 This is because according to TypeScript documentation, > Packages in `node_modules/@types` of any enclosing folder are considered *visible*. So we can't have `@types` in the root `node_modules` folder, otherwise ecosystem projects in the `workspace` folder will be able to see them, and that might affect the type checking result.
vuejs · Nov 30, 2023 · af22599 · af22599
1 parent 156d2e4
commit af22599
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 9 deletions.
diff --git a/package.json b/package.json
@@ -50,7 +50,6 @@
  },
  "devDependencies": {
  "@antfu/ni": "^0.21.4",
- "@types/node": "^18.16.19",
  "@typescript-eslint/eslint-plugin": "^5.62.0",
  "@typescript-eslint/parser": "^5.62.0",
  "eslint": "^8.45.0",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/tsconfig.json b/tsconfig.json
@@ -13,6 +13,7 @@
  "useUnknownInCatchVariables": false,
  "allowSyntheticDefaultImports": true,
  "lib": ["esnext"],
- "sourceMap": true
+ "sourceMap": true,
+ "typeRoots": ["./typings/node_modules/@types"]
  }
 }
diff --git a/typings/package.json b/typings/package.json
@@ -0,0 +1,9 @@
+{
+ "name": "typings",
+ "version": "0.0.0",
+ "private": true,
+ "description": "Alternative typing root directory for the project in order not to pollute the root node_modules",
+ "devDependencies": {
+ "@types/node": "^18.18.14"
+ }
+}
diff --git a/typings/pnpm-lock.yaml b/typings/pnpm-lock.yaml