Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @eslint-typescript to v6 #58

Closed
frsimond opened this issue Aug 3, 2023 · 4 comments · Fixed by #61
Closed

Upgrade @eslint-typescript to v6 #58

frsimond opened this issue Aug 3, 2023 · 4 comments · Fixed by #61
Labels
enhancement New feature or request

Comments

@frsimond
Copy link

frsimond commented Aug 3, 2023

If I use this package with the latest typescript and vue versions (ie: 5.1.x and 3.3.x) I get this message.

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.1.0

YOUR TYPESCRIPT VERSION: 5.1.6

Please only submit bug reports when using the officially supported version.

But vue's repo's packages.json do not mention any limitations regarding the typescript version to be used with.

Three weeks ago, typescript-eslint released the v6.0.0 and eslint-config-airbnb-typescript followed right after with the v17.1.0.

Unlike what eslint-config-airbnb-typescript did and because of @rushstack/eslint-patch, I personnally think this package should target the latest version only. But if so rules breaking changes should be mentionned in the release and therefore it might need a Major version bump (ie: v8.0.0).

What do you think @sodatea ?

@haoqunjiang haoqunjiang added the enhancement New feature or request label Aug 5, 2023
@PurpleTape
Copy link

Any updates? 🥺🥺🥺

@frsimond
Copy link
Author

frsimond commented Sep 5, 2023

@PurpleTape I've tried to make a nice PR for this. But I am affraid to make opinionated decisions and I am really short on time for the moment.
I would rather have @sodatea or an regular vue maintener handle this :)

undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this issue Oct 15, 2023
This commit updates various dependencies to their latest versions.

Other changes include:

- Moved the following from `devDependencies` to `dependencies`:
  - `electron-log`
  - `electron-updater`
- Remove `npm` dependency.
- Add type casting in several places to align with the latest
  `typescript` version.
- Dependencies not upgraded due to
  `@vue/eslint-config-airbnb-with-typescript` not supporting
  `@eslint-typescript` V6 (see vuejs/eslint-config-airbnb#58):
  - `vue/eslint-config-typescript`
  - `@typescript-eslint/eslint-plugin`
  - `@typescript-eslint/parser`
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this issue Oct 15, 2023
This commit updates various dependencies to their latest versions.

Other changes include:

- Moved the following from `devDependencies` to `dependencies`:
  - `electron-log`
  - `electron-updater`
- Remove `npm` dependency.
- Add type casting in several places to align with the latest
  `typescript` version.
- Dependencies not upgraded due to
  `@vue/eslint-config-airbnb-with-typescript` not supporting
  `@eslint-typescript` V6 (see vuejs/eslint-config-airbnb#58):
  - `vue/eslint-config-typescript`
  - `@typescript-eslint/eslint-plugin`
  - `@typescript-eslint/parser`
- Enable video recording for cypress as it's disabled by default since
  13.X.X.
@undergroundwires
Copy link

undergroundwires commented Oct 15, 2023

This is blocking upgrading following dependencies for me:

  • vue/eslint-config-typescript
  • @typescript-eslint/eslint-plugin
  • @typescript-eslint/parser

Can we please take a look at this @sodatea ❤️? Your work is highly appreciated and it's very nice to provide this package to community. But it has gotten so outdated that it has become a blocker for our modern TypeScript development. I think it deserves some attention. Quoting Vue.js homepage:

Vue is written in TypeScript itself and provides first-class TypeScript support.

undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this issue Oct 15, 2023
This commit updates various dependencies to their latest versions.

Other changes include:

- Moved the following from `devDependencies` to `dependencies`:
  - `electron-log`
  - `electron-updater`
- Remove `npm` dependency.
- Code changes:
  - Add type casting in several places to align with the latest
    `typescript` version.
  - Adopt to new return type of `setTimeout`.
- Dependencies not upgraded due to
  `@vue/eslint-config-airbnb-with-typescript` not supporting
  `@eslint-typescript` V6 (see vuejs/eslint-config-airbnb#58):
  - `vue/eslint-config-typescript`
  - `@typescript-eslint/eslint-plugin`
  - `@typescript-eslint/parser`
- Enable video recording for cypress as it's disabled by default since
  13.X.X.
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this issue Oct 16, 2023
This commit updates various dependencies to their latest versions.

Other changes include:

- Moved the following from `devDependencies` to `dependencies`:
  - `electron-log`
  - `electron-updater`
- Remove `npm` dependency.
- Code changes:
  - Add type casting in several places to align with the latest
    `typescript` version.
  - Adopt to new return type of `setTimeout`.
- Dependencies not upgraded due to
  `@vue/eslint-config-airbnb-with-typescript` not supporting
  `@eslint-typescript` V6 (see vuejs/eslint-config-airbnb#58):
  - `vue/eslint-config-typescript`
  - `@typescript-eslint/eslint-plugin`
  - `@typescript-eslint/parser`
- Enable video recording for cypress as it's disabled by default since
  13.X.X.
@everyx
Copy link

everyx commented Oct 27, 2023

There is a workaround if you're using PNPM, you can use PNPM overrides to force using version 6.x:
Add to your package.json:

 "pnpm": {
    "overrides": {
      "@typescript-eslint/parser": "6.9.0"
    }
  }

Then run pnpm install again

LarrMarburger added a commit to LarrMarburger/privacy.sexy that referenced this issue Nov 16, 2023
This commit updates various dependencies to their latest versions.

Other changes include:

- Moved the following from `devDependencies` to `dependencies`:
  - `electron-log`
  - `electron-updater`
- Remove `npm` dependency.
- Code changes:
  - Add type casting in several places to align with the latest
    `typescript` version.
  - Adopt to new return type of `setTimeout`.
- Dependencies not upgraded due to
  `@vue/eslint-config-airbnb-with-typescript` not supporting
  `@eslint-typescript` V6 (see vuejs/eslint-config-airbnb#58):
  - `vue/eslint-config-typescript`
  - `@typescript-eslint/eslint-plugin`
  - `@typescript-eslint/parser`
- Enable video recording for cypress as it's disabled by default since
  13.X.X.
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this issue Jan 4, 2024
- Bump all ESLint dependencies related to TypeScript to their latest
  version. This was made possible by the resolution of compatibility
  issues with `@vue/eslint-config-airbnb-with-typescript`.
  See vuejs/eslint-config-airbnb#58 for details.
- Refactor code to comply with the latest linting configuration.
- Improve documentation in the ESLint configuration file to better
  describe the functionality and limitations of
  `@vue/typescript/recommended`.
  See vuejs/eslint-config-typescript/issues#67 for details.
- Document functionality and limitation of `@vue/typescript/recommended`
  more clearly in ESLint configuration file.
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this issue Jan 5, 2024
- Bump all ESLint dependencies related to TypeScript to their latest
  version. This was made possible by the resolution of compatibility
  issues with `@vue/eslint-config-airbnb-with-typescript`.
  See vuejs/eslint-config-airbnb#58 for details.
- Refactor code to comply with the latest linting configuration.
- Improve documentation in the ESLint configuration file to better
  describe the functionality and limitations of
  `@vue/typescript/recommended`.
  See vuejs/eslint-config-typescript#67 for details.
- Document functionality and limitation of `@vue/typescript/recommended`
  more clearly in ESLint configuration file.
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this issue Jan 5, 2024
- Bump all ESLint dependencies related to TypeScript to their latest
  version. This was made possible by the resolution of compatibility
  issues with `@vue/eslint-config-airbnb-with-typescript`.
  See vuejs/eslint-config-airbnb#58 for details.
- Refactor code to comply with the latest linting configuration.
- Improve documentation in the ESLint configuration file to better
  describe the functionality and limitations of
  `@vue/typescript/recommended`.
  See vuejs/eslint-config-typescript#67 for details.
- Document functionality and limitation of `@vue/typescript/recommended`
  more clearly in ESLint configuration file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants