Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional typescript-eslint configs #73

Closed
rijenkii opened this issue Mar 15, 2024 · 4 comments · Fixed by #81
Closed

Support additional typescript-eslint configs #73

rijenkii opened this issue Mar 15, 2024 · 4 comments · Fixed by #81

Comments

@rijenkii
Copy link

https://typescript-eslint.io/users/configs#recommended-configurations:

  • recommended-type-checked(-only)
  • strict(-type-checked(-only))
  • stylistic(-type-checked(-only))
  • all
  • base
  • disable-type-checked

Currently it seems that only eslint-recommended and recommended are provided.

@bmulholland
Copy link
Contributor

@haoqunjiang This was closed by #81, but that PR notes "I'm afraid I can't get the *-type-checked configurations right on the first try; I'm not sure about the performance in large projects either"

I spent a while trying to get this working and was confused by the error I got: Cannot read properties of undefined (reading 'files')

I guess this didn't actually make it in, and should be re-opened?

@bmulholland
Copy link
Contributor

Ah but this is a dupe of the older #67, right?

@haoqunjiang
Copy link
Member

I spent a while trying to get this working and was confused by the error I got: Cannot read properties of undefined (reading 'files')

You might have accidentally used the kebab-case names instead of camelCase.
It was an unfortunate oversight when I implemented this feature, but I can't change that now due to semver constraints, and supporting both cases would mess up the TypeScript suggestions.
In v14.1.2 I added more friendly error messages for such errors. Could you try it out?

@bmulholland
Copy link
Contributor

bmulholland commented Oct 22, 2024

@haoqunjiang Ah nice. Yes, that was it. I upgraded and tried again; the error message appeared as expected and would have saved me time. Cool, all good then. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants