Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip typechecking cjs and mjs files #94

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: skip typechecking cjs and mjs files #94

merged 1 commit into from
Oct 23, 2024

Conversation

henribru
Copy link
Contributor

I have a postcss.config.cjs in my project, and when using the typechecked config recommended in the README, I ended up getting

Error: Error while loading rule '@typescript-eslint/await-thenable': You have used a rule which requires type information, but don't have parserOptions set to generate type information for this file. See https://typescript-eslint.io/getting-started/typed-linting for enabling linting with type information.
Parser: typescript-eslint/parser
Occurred while linting /.../postcss.config.cjs

Such issues can be avoided by not just skipping .js files, but also .cjs and .mjs. Since .cjs and .mjs files are also Javascript files I believe this makes sense.

haoqunjiang
haoqunjiang approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@haoqunjiang haoqunjiang merged commit a6cb23d into vuejs:main Oct 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henribru @haoqunjiang