Skip to content
This repository was archived by the owner on Jan 18, 2022. It is now read-only.

Remove eslint-plugin-vue from dependencies #9

Closed
wants to merge 3 commits into from
Closed

Conversation

znck
Copy link
Member

@znck znck commented Jan 16, 2017

eslint-plugin-html v2 (support for --fix) is not compatible with eslint-plugin-vue. Forcing eslint-plugin-vue, makes eslint-config-vue unusable.

Related vuejs/eslint-plugin-vue#3

znck added 3 commits January 16, 2017 19:07
Removing `eslint-plugin-vue` allows using config without forcing the plugin.

Also, `eslint-plugin-vue` does not support next version of `eslint-plugin-html`, it's better to leave the choice for user.
@znck znck requested a review from yyx990803 January 17, 2017 13:05
@chrisvfritz
Copy link
Contributor

@znck I'm wondering if we should close this PR in favor of just broadening the accepted version in the peer dependency. This can even be a patch release here, since if we publish the new eslint-plugin-vue with a beta tag as discussed, there's no risk of accidentally opting in.

@znck
Copy link
Member Author

znck commented Jan 17, 2017

👍 Sounds cool.

@znck znck closed this Jan 17, 2017
@znck znck removed the request for review from yyx990803 January 17, 2017 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants