New: Add vue/no-watch-after-await rule
#1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was unable to reproduce this asynchronous issue with Vue3 "setup". |
|
I have found that registering a watch asynchronously has the problem that the watch remains after the instance of the Vue component is destroyed. |
|
Hmm... but, the remaining watches can be deleted with StopHandle. |
ota-meshi
force-pushed
the
add-rule/no-watch-after-await
branch
from
902d352 to
6bea92e
Compare
ota-meshi
force-pushed
the
add-rule/no-watch-after-await
branch
from
6bea92e to
7d22e76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
vue/no-watch-after-awaitrule.The
vue/no-watch-after-awaitrule reports thewatch()afterawaitexpression.ref #1035