Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Add vue/no-deprecated-data-object-declaration rule #1083

Merged

Conversation

yoyo930021
Copy link
Member

This PR adds the vue/no-deprecated-data-object-declaration rule.

This rule reports use of deprecated object declaration on data property.

RFC0019
ref #1035

@ota-meshi
Copy link
Member

Thank you for this PR.

However, I think it is the same as the no-shared-component-data rule.

@yoyo930021
Copy link
Member Author

yoyo930021 commented Mar 23, 2020

The root instance is also disallowed object declaration on Vue 3.0.
I think can change it and rename?

@ota-meshi
Copy link
Member

Thank you for information. You're right.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
I have some requests.

@yoyo930021 yoyo930021 force-pushed the add-no-deprecated-data-object-declaration branch from b173573 to 37bc2ce Compare March 31, 2020 13:14
@yoyo930021 yoyo930021 requested a review from ota-meshi March 31, 2020 13:16
@yoyo930021
Copy link
Member Author

yoyo930021 commented Mar 31, 2020

I finished the change.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit 7609be6 into vuejs:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants