Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detect Vue3 defineComponent #1088

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Fix detect Vue3 defineComponent #1088

merged 2 commits into from
Apr 21, 2020

Conversation

yoyo930021
Copy link
Member

@yoyo930021 yoyo930021 commented Mar 31, 2020 •
edited
Loading

The defineComponent function is also a Vue3 component.

ref: https://vue-composition-api-rfc.netlify.com/api.html#definecomponent #1035

ota-meshi
ota-meshi approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit cadec3b into vuejs:master Apr 21, 2020
@sugitata sugitata mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
semver-major Vue.js 3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoyo930021 @ota-meshi