-
-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new attributes order for dynamic and static props #2068
Add new attributes order for dynamic and static props #2068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you! I don't know why the Netlify deployment is failing, but it doesn't seem to be related to your changes. @ota-meshi, could you please have a look at that?
@GreatGui, I commented a few smaller issues. Also, have you seen #1870? It would be great to implement both options in one pull request to avoid a breaking change.
So, would you fancy also implementing the following to fix #1870?
OTHER_ATTR_STATIC
should only match non-shorthand attributes (e.g.foo="bar"
but notfoo
on its own).- Introduce new option
OTHER_ATTR_SHORTHAND_BOOL
that matches shorthand boolean attributes. OTHER_ATTR
should be an alias for[OTHER_ATTR_DYNAMIC, OTHER_ATTR_STATIC, OTHER_ATTR_SHORTHAND_BOOL]
.
@FloEdelmann I corrected everything I could and added the |
@GreatGui It would be good to get this into the next version, could you please check the open threads? If you don't have time, I'll do the rest. |
@FloEdelmann fixed the points and added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing all the feedback!
This PR adds
[ 'ATTR_STATIC', 'ATTR_DYNAMIC', 'ATTR_SHORTHAND_BOOL' ]
attribute tovue/attributes-order
. AndOTHER_ATTR
become an alias for [ 'ATTR_STATIC', 'ATTR_DYNAMIC', 'ATTR_SHORTHAND_BOOL' ]close #1728, close #1870