Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint this repo using ESLint Flat Config #2226

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Conversation

nzakas
Copy link
Contributor

@nzakas nzakas commented Jun 29, 2023

This PR switches the repo to use flat config for ESLint. The goal of this exercise is to test out flat config on popular ESLint plugins to make sure things will work. To do that, I:

  • Added a eslint.config.js file
  • Deleted .eslintrc.js and .eslintignore
  • Modified existing files that referenced local rules
  • Updated the tools/update scripts to use flat config

I did not make any changes to the plugin itself, this is just the linting for this repo that was updated.

I've tested this to make sure that it outputs the same results as with the eslintrc config system, but please let me know if I missed anything.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, thank you!

What would be the next steps? FlatCompat and eslint/use-at-your-own-risk look like they need to be changed at some point 😉

@FloEdelmann FloEdelmann requested a review from ota-meshi June 30, 2023 07:58
@FloEdelmann FloEdelmann changed the title chore: Switch to flat config for ESLint Lint this repo using ESLint Flat Config Jun 30, 2023
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@ota-meshi ota-meshi merged commit 2aa9ac4 into vuejs:master Jun 30, 2023
@nzakas
Copy link
Contributor Author

nzakas commented Jun 30, 2023

@FloEdelmann yes, they'll need to be changed, but at least through ESLint v9 this code will continue to work, so there will be plenty of time to adjust as needed.

@nzakas nzakas deleted the flat-config branch June 30, 2023 19:09
@FloEdelmann FloEdelmann added the meta Code style improvements, build process improvements, refactorings label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Code style improvements, build process improvements, refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants