Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs and error message for vue/no-dupe-keys #2260

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Improve docs and error message for vue/no-dupe-keys #2260

merged 5 commits into from
Aug 1, 2023

Conversation

vincerubinetti
Copy link
Contributor

@vincerubinetti vincerubinetti commented Jul 31, 2023 •
edited
Loading

Closes #2247

  • Update error message for no-dupe-keys and related tests.
  • Clarify no-dupe-keys doc page.
  • Use "duplicate" consistently instead of "duplicated".
  • Fix english error on unrelated rules.

Side note, I wish this rule was named no-duplicate-keys for consistency with other duplicate rules, but this would be a breaking change.

@vincerubinetti
Copy link
Contributor Author

vincerubinetti commented Jul 31, 2023 •
edited
Loading

I think I accidentally formatted this with Prettier (my config) out of habit, which added semi colons and commas and such. Let me try to fix.

@vincerubinetti
Copy link
Contributor Author

Okay should be fixed. Sorry for the messy commits. Hopefully you do squash merges.

FloEdelmann
FloEdelmann approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 👍

We use squash commits, so the messy commit history in this PR is no problem at all 🙂

@FloEdelmann FloEdelmann changed the title Touchup docs and error message for no-dupe-keys Improve docs and error message for vue/no-dupe-keys Aug 1, 2023
@FloEdelmann FloEdelmann merged commit 101cabf into vuejs:master Aug 1, 2023
@vincerubinetti vincerubinetti deleted the dupe-keys-docs branch August 1, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message for vue/no-dupe-keys
2 participants
@vincerubinetti @FloEdelmann