Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add externalIgnores option for vue/singleline-html-element-content-newline #2297

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

qmhc
Copy link
Contributor

@qmhc qmhc commented Oct 19, 2023

What to be solved

When users want to customize ignores option for vue/singleline-html-element-content-newline rule and don't want to lose the ignored elements which are specified by default, it's a hard work.

A long list is defined in utils/inline-non-void-elements.json, and user need to define it again in their config.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that makes sense. Thanks for your contribution!

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the late review.

@ota-meshi ota-meshi merged commit ac57432 into vuejs:master Nov 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants