Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: move index.js and configs #23

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Fix: move index.js and configs #23

merged 1 commit into from
Jun 15, 2017

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Jun 15, 2017

It have thrown "Module not found" error when I do require("eslint-plugin-vue") with 3.0.0 because the package.json has main: "lib/index.js" field and the lib/index.js does not exist.

This PR moves files:

  • index.jslib/index.js
  • Incidentally, configlib/config because I think that the config directory should exist at the same level as rules directory.

@yyx990803 yyx990803 requested a review from michalsnik June 15, 2017 05:11
Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. I thought eslint-generator puts index out of lib directory by default so I moved it. Thanks for catching this!

@michalsnik michalsnik merged commit 5da8841 into dev Jun 15, 2017
@michalsnik michalsnik deleted the fix-index branch June 15, 2017 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants