Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid calling typeParameters getter #2327

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix: avoid calling typeParameters getter #2327

merged 1 commit into from
Nov 29, 2023

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented Nov 27, 2023

#2292

typeParameters was still being accessed when typeArguments is undefined

ota-meshi
ota-meshi approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit e008d34 into vuejs:master Nov 29, 2023
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaelWD @ota-meshi