Add selfClosingTag option to vue/html-closing-bracket-newline
#2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mussinbenarbia
changed the title
selfClosingTag option to vue/html-closing-bracket-newline
|
I plan to update the docs once the implementation is confirmed/approved 🙇 Should I mark the PR as draft when I do this? Or should I let the maintainers do it? |
FloEdelmann
reviewed
Dec 5, 2023
Yes please; it makes it clear that the PR is not intended to be complete yet. |
FloEdelmann
reviewed
Dec 6, 2023
|
@FloEdelmann Oops, I re-requested review before finishing the docs. I'm on them right now |
|
@FloEdelmann Docs updated. I tried to follow the same structure as https://eslint.vuejs.org/rules/html-self-closing Let me know if that looks OK! |
FloEdelmann
reviewed
Dec 7, 2023
This commit also adds a missing whitespace
FloEdelmann
approved these changes
Dec 7, 2023
FloEdelmann
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1794
The implementation follows @ota-meshi's suggestion of adding a
selfClosingTagoption to thehtml-closing-bracket-newlinerule.It keeps compatibility by falling back to the previous behavior if the user does not specify the new option.