Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new vue/no-restricted-v-on rule #2367

Merged
merged 17 commits into from
Jan 16, 2024

Conversation

thesheppard
Copy link
Contributor

This is an attempt at solving #2243

Keen for feedback 🫡

@thesheppard thesheppard changed the title Add new vue/no-restricted-v-on rule (#2243) Add new vue/no-restricted-v-on rule Jan 12, 2024
@FloEdelmann FloEdelmann linked an issue Jan 12, 2024 that may be closed by this pull request
docs/rules/no-restricted-v-on.md Outdated Show resolved Hide resolved
lib/rules/no-restricted-v-on.js Outdated Show resolved Hide resolved
lib/rules/no-restricted-v-on.js Outdated Show resolved Hide resolved
lib/rules/no-restricted-v-on.js Show resolved Hide resolved
lib/rules/no-restricted-v-on.js Outdated Show resolved Hide resolved
lib/rules/no-restricted-v-on.js Outdated Show resolved Hide resolved
tests/lib/rules/no-restricted-v-on.js Outdated Show resolved Hide resolved
thesheppard and others added 6 commits January 12, 2024 20:14
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
@thesheppard
Copy link
Contributor Author

Have addressed PR comments, it's ready for another look 💪🏾

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool, thanks for the implementing the feedback so quickly! I have just one final remark regarding the docs. Other than that, it looks good already 🙂

docs/rules/no-restricted-v-on.md Show resolved Hide resolved
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more minor docs improvement suggestions. Thanks!

docs/rules/no-restricted-v-on.md Outdated Show resolved Hide resolved
docs/rules/no-restricted-v-on.md Outdated Show resolved Hide resolved
thesheppard and others added 3 commits January 13, 2024 14:21
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
@thesheppard
Copy link
Contributor Author

I've added the links to the related docs 🙏🏾

@FloEdelmann FloEdelmann requested a review from ota-meshi January 13, 2024 14:21
lib/rules/no-restricted-v-on.js Outdated Show resolved Hide resolved
@thesheppard thesheppard requested a review from ota-meshi January 16, 2024 10:30
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 7d13ce3 into vuejs:master Jan 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule suggestion: vue/no-restricted-v-on
3 participants