Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v-bind-style): add sameNameShorthand option #2381

Merged
merged 9 commits into from
Jan 29, 2024
Merged

feat(v-bind-style): add sameNameShorthand option #2381

merged 9 commits into from
Jan 29, 2024

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Jan 28, 2024

close #2359.

This implementation follows #2359 (comment) and #2374 (comment) of adding a sameNameShorthand option to the v-bind-style rule.

@waynzh waynzh force-pushed the feature/v-bind-style-add-new-option branch from c4be00b to a663270 Compare January 28, 2024 07:01
@waynzh
Copy link
Member Author

waynzh commented Jan 28, 2024

Seems the tests are failing, but they all pass locally. Trying to figure out why 🤔

@ota-meshi
Copy link
Member

Thank you for this PR!!!
The CI error seems to be a bug in the main branch. Don't worry about it now.

ota-meshi
ota-meshi approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ota-meshi ota-meshi requested a review from FloEdelmann January 28, 2024 08:21
@ota-meshi ota-meshi mentioned this pull request Jan 28, 2024
Merged
FloEdelmann
FloEdelmann requested changes Jan 29, 2024
View reviewed changes
docs/rules/v-bind-style.md Outdated Show resolved Hide resolved
lib/rules/v-bind-style.js Outdated Show resolved Hide resolved
lib/rules/v-bind-style.js Outdated Show resolved Hide resolved
lib/rules/v-bind-style.js Outdated Show resolved Hide resolved
waynzh and others added 2 commits January 29, 2024 19:37
@waynzh @FloEdelmann
Update docs/rules/v-bind-style.md
155c09e 
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
@waynzh @FloEdelmann
Update lib/rules/v-bind-style.js
1b93262 
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
@FloEdelmann
Copy link
Member

Seems the tests are failing

They were fixed in #2382. You can pull the latest changes from master (with the "Update branch" button on GitHub) to fix the CI.

waynzh and others added 4 commits January 29, 2024 19:38
@waynzh
Copy link
Member Author

waynzh commented Jan 29, 2024

Thanks for the review!

@FloEdelmann
Copy link
Member

Thanks for applying the suggestions so quickly!

@FloEdelmann FloEdelmann merged commit 2dc7889 into vuejs:master Jan 29, 2024
17 checks passed
@hashim21223445 hashim21223445 mentioned this pull request Jul 29, 2024
Merged
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce/disallow v-bind same name shorthand style
3 participants
@waynzh @ota-meshi @FloEdelmann