Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-unused-emit-declarations): error in render functions #2388

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

ntnyq
Copy link
Contributor

@ntnyq ntnyq commented Jan 31, 2024

Fix #2387

Don't know how to describe the commit message properly.

Feel free to edit it.

@FloEdelmann FloEdelmann changed the title fix(no-unused-emit-declarations): miss empty Set assert fix(no-unused-emit-declarations): error in render functions Jan 31, 2024
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and fixing this bug! And thanks for adding unit tests!

@FloEdelmann FloEdelmann requested a review from ota-meshi January 31, 2024 09:35
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit b7ccbbd into vuejs:master Jan 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue/no-unused-emit-declarations would throw Error when using dynamic render
3 participants