Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add prefer-use-template-ref rule #2554

Merged
merged 20 commits into from
Nov 11, 2024
Merged

feat: add prefer-use-template-ref rule #2554

merged 20 commits into from
Nov 11, 2024
+485 −0

Conversation

Thomasan1999
Copy link
Contributor

resolves #2549

FloEdelmann
FloEdelmann requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🙂

I have a few comments.

lib/rules/prefer-use-template-ref.js Outdated Show resolved Hide resolved
tests/lib/rules/prefer-use-template-ref.js Show resolved Hide resolved
tests/lib/rules/prefer-use-template-ref.js Outdated Show resolved Hide resolved
docs/rules/prefer-use-template-ref.md Outdated Show resolved Hide resolved
docs/rules/prefer-use-template-ref.md Outdated Show resolved Hide resolved
docs/rules/prefer-use-template-ref.md Outdated Show resolved Hide resolved
ota-meshi
ota-meshi requested changes Sep 18, 2024
View reviewed changes
lib/rules/prefer-use-template-ref.js Outdated Show resolved Hide resolved
tests/lib/rules/prefer-use-template-ref.js Show resolved Hide resolved
tests/lib/rules/prefer-use-template-ref.js Outdated Show resolved Hide resolved
docs/rules/prefer-use-template-ref.md Show resolved Hide resolved
@maxfrees

This comment was marked as spam.

Sign in to view
@Thomasan1999
Copy link
Contributor Author

any update

@maxfrees I will split it to 2 PRs as @ota-meshi suggested. Sorry for the delay, I was not able to get to it recently, will try to finish at least the first part this weekend, most of it is already done.

@Thomasan1999
Copy link
Contributor Author

@FloEdelmann @ota-meshi Implemented all of your feedback. 🙂

ota-meshi
ota-meshi approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

FloEdelmann
FloEdelmann approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@FloEdelmann FloEdelmann merged commit a5fb774 into vuejs:master Nov 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: vue/prefer-use-template-ref
4 participants
@Thomasan1999 @maxfrees @FloEdelmann @ota-meshi