Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prefer-use-template-ref): add support for shallowRef #2608

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

ntnyq
Copy link
Contributor

@ntnyq ntnyq commented Nov 15, 2024

This PR adds shallowRef support to rule prefer-use-template-ref.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement! I have a few minor comments but they should be easy to resolve.

lib/rules/prefer-use-template-ref.js Outdated Show resolved Hide resolved
lib/rules/prefer-use-template-ref.js Outdated Show resolved Hide resolved
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 🙂

@FloEdelmann
Copy link
Member

I'll merge this without @ota-meshi's review now to make conflict resolution possible in #2612. But feel free to comment on it afterwards!

@FloEdelmann FloEdelmann merged commit 4500389 into vuejs:master Nov 18, 2024
18 checks passed
Thomasan1999 added a commit to Thomasan1999/eslint-plugin-vue that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants