🐛Fix: incorrect indentation in vue/script-indent rule
#503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eport whileforce using semicolon.
|
👍 |
michalsnik
approved these changes
Sep 13, 2018
lib/utils/indent-common.js
Outdated
| const trivial = isTrivialToken(tokens[0]) | ||
| let expectedIndent = Number.MAX_SAFE_INTEGER | ||
| function getExpectedIndents (tokens) { | ||
| const expectedIndents = [] | ||
|
|
||
| for (let i = 0; i < tokens.length; ++i) { | ||
| const token = tokens[i] | ||
| const offsetInfo = offsets.get(token) | ||
|
|
||
| // If the first token is not trivial then ignore trivial following tokens. |
There was a problem hiding this comment.
Looks like this comment is not relevant anymore
There was a problem hiding this comment.
@michalsnik I have a question, If this PR is merged, how can I install latest eslint-plugin-vue with fixed code ?
|
@michalsnik Thank you for pointing out. |
|
Hi! |
|
Alright, let's give it a spin while we're still in beta and the rule is still |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #441,#443