Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐️New: Add vue/no-deprecated-slot-attribute rule #839

Merged
merged 5 commits into from
Dec 26, 2019

Conversation

ota-meshi
Copy link
Member

vue/no-deprecated-slot-attribute rule reports deprecated slot attribute in Vue.js v2.6.0+.

<template>
  <ListComponent>
    <!-- ✓ GOOD -->
    <template v-slot:name>
      {{ props.title }}
    </template>
  </ListComponent>
  <ListComponent>
    <!-- ✗ BAD -->
    <template slot="name">
      {{ props.title }}
    </template>
  </ListComponent>
</template>

refs #800 (comment)

Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this rule!

Almost LGTM, but I have a few suggestions.

lib/rules/syntaxes/slot-attribute.js Outdated Show resolved Hide resolved
lib/rules/syntaxes/slot-attribute.js Outdated Show resolved Hide resolved
- Changed to check `v-bind:slot`.
- Changed not to autofix, if it becomes an invalid attribute name after autofix.
@ota-meshi
Copy link
Member Author

Thank you for your review!
I changed this. please check again.

Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I had overlooked this in the previous review.

output: `
<template>
<LinkList>
<a v-slot:name />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, sorry, I had overlooked this in the previous review.

In some cases, slot and v-slot should be in different places.

  • v-slot must be on a <template> element which is a direct child of a custom element.
  • v-slot for the default slot can be on a custom element directly if there are no named slots.

So in this case, the <a> element must be wrapped by a <template> element.

In the example of nested default slots, it will be moved to the parent element.

Therefore, autofix may be tough to implement... 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply.
Thank you for pointing this out.

Sorry, I did not understand v-slot correctly.
I will change it so that it will only autofix if slot is attached to <template>.

@ota-meshi ota-meshi self-assigned this Apr 2, 2019
@ota-meshi ota-meshi requested a review from mysticatea November 14, 2019 02:05
@ota-meshi ota-meshi merged commit 3306b03 into master Dec 26, 2019
@ota-meshi ota-meshi deleted the add-rule/no-deprecated-slot-attribute branch December 26, 2019 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants