Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickup Video from original repo #558

Merged
merged 2 commits into from
Dec 21, 2017
Merged

Pickup Video from original repo #558

merged 2 commits into from
Dec 21, 2017

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Dec 20, 2017

closes #537 #554

whosdustin and others added 2 commits December 21, 2017 00:49
* Add icons play and dark GitHub icon.

* Increase width and update margins of inner class

* Add modal for video player

* Add and update hero buttons

* Add Vimeo analytics

* Update video with correct video url

* Add autoplay on video open

* Add aria and lang to svgs

* Rename Github button

* rename class for button with icon

* Update class for icon in html
@kazupon kazupon requested review from re-fort and potato4d December 20, 2017 15:52
@kazupon
Copy link
Member Author

kazupon commented Dec 20, 2017

動画の翻訳は流石にむりですね。 😅

@kazupon
Copy link
Member Author

kazupon commented Dec 21, 2017

@re-fort @potato4d
本家の方に、動画翻訳の issue が立ち上がりましたね。
vuejs/v2.vuejs.org#1337

一旦、このPRはマージして、Issue 立ち上げましょうか?

@re-fort
Copy link
Collaborator

re-fort commented Dec 21, 2017

@kazupon
はい、それでよいと思います🙆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: Why Vue video for the Front Page (#1325)
4 participants