perf: find destructured props only with enabled setting

vuejs · Sep 5, 2024 · fa6f059 · fa6f059
1 parent 1dafe62
commit fa6f059
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 12 deletions.
diff --git a/extensions/vscode/package.json b/extensions/vscode/package.json
@@ -389,7 +389,7 @@
 				"vue.inlayHints.destructuredProps": {
 					"type": "boolean",
 					"default": false,
-					"description": "Show inlay hints for destructured prop."
+					"description": "Show inlay hints for destructured props."
 				},
 				"vue.inlayHints.missingProps": {
 					"type": "boolean",

diff --git a/packages/language-service/lib/plugins/vue-inlayhints.ts b/packages/language-service/lib/plugins/vue-inlayhints.ts
@@ -32,17 +32,22 @@ export function create(ts: typeof import('typescript')): LanguageServicePlugin {
 						const scriptSetupRanges = codegen?.scriptSetupRanges();
 
 						if (scriptSetupRanges?.props.destructured && virtualCode.sfc.scriptSetup?.ast) {
-							for (const [prop, isShorthand] of findDestructuredProps(ts, virtualCode.sfc.scriptSetup.ast, scriptSetupRanges.props.destructured)) {
-								const name = prop.text;
-								const end = prop.getEnd();
-								const pos = isShorthand ? end : end - name.length;
-								const label = isShorthand ? `: props.${name}` : 'props.';
-								inlayHints.push({
-									blockName: 'scriptSetup',
-									offset: pos,
-									setting: 'vue.inlayHints.destructuredProps',
-									label,
-								});
+							const setting = 'vue.inlayHints.destructuredProps';
+							settings[setting] ??= await context.env.getConfiguration?.<boolean>(setting) ?? false;
+
+							if (settings[setting]) {
+								for (const [prop, isShorthand] of findDestructuredProps(ts, virtualCode.sfc.scriptSetup.ast, scriptSetupRanges.props.destructured)) {
+									const name = prop.text;
+									const end = prop.getEnd();
+									const pos = isShorthand ? end : end - name.length;
+									const label = isShorthand ? `: props.${name}` : 'props.';
+									inlayHints.push({
+										blockName: 'scriptSetup',
+										offset: pos,
+										setting,
+										label,
+									});
+								}
 							}
 						}